Bump aws-sdk-go to v1.25.43 to support IRSA for pods EKS #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PettitWesley
reviewed
Dec 3, 2019
PettitWesley
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Ran integ tests as shown here just to be safe: https://github.com/aws/aws-for-fluent-bit#development
PettitWesley
reviewed
Dec 3, 2019
go.sum
Outdated
| @@ -4,6 +4,8 @@ github.com/aws/amazon-kinesis-firehose-for-fluent-bit v0.0.0-20190723183349-6ca3 | |||
| github.com/aws/amazon-kinesis-firehose-for-fluent-bit v0.0.0-20190723183349-6ca31170fc03/go.mod h1:jZjLd+hsaK0oNVotfqbMK9gUsIhXvYEl7Z3tdZTYa54= | |||
| github.com/aws/aws-sdk-go v1.20.6 h1:kmy4Gvdlyez1fV4kw5RYxZzWKVyuHZHgPWeU/YvRsV4= | |||
| github.com/aws/aws-sdk-go v1.20.6/go.mod h1:KmX6BPdI08NWTb3/sm4ZGu5ShLoqVDhKgpiN924inxo= | |||
There was a problem hiding this comment.
Old SDK is still in the go.sum
Fix this by running go mod tidy
There was a problem hiding this comment.
For some reason, go mod tidy does not fix this issue. It looks like, we might need a new release for amazon-kinesis-firehose-for-fluent-bit where this dependency is coming from!
There was a problem hiding this comment.
I finally figured this out. By default, go mod uses the latest git tag from a repo- which is v1.0.0 for firehose.
But you can tell it to just use the latest master:
go get github.com/aws/amazon-kinesis-firehose-for-fluent-bit@master
I ran that on your branch, and it fixed it.
nithu0115
force-pushed
the
master
branch
4 times, most recently
from
b94cff3 to
ec618d1
Compare
PettitWesley
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Bumping aws-sdk-go to v1.25.43 to support IRSA for pods EKS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.